On Wed, Apr 24, 2024 at 05:26:41PM -0700, Florian Fainelli wrote: > Rather than open code the i2c_designware string, utilize the newly > defined constant in i2c-designware.h. ... > +++ b/drivers/mfd/intel_quark_i2c_gpio.c > @@ -17,6 +17,7 @@ > #include <linux/clk-provider.h> > #include <linux/dmi.h> > #include <linux/i2c.h> > +#include <linux/platform_data/i2c-designware.h> Make it a separate group after linux/* ... > #include <linux/property.h> > ...here. ... > -#define INTEL_QUARK_I2C_CONTROLLER_CLK "i2c_designware.0" > +#define INTEL_QUARK_I2C_CONTROLLER_CLK I2C_DESIGNWARE_NAME ".0" I'm not fan of this, but I think creating another macro to help with constant device instance naming might be more cumbersome and overkill. -- With Best Regards, Andy Shevchenko
