Tue, Apr 23, 2024 at 04:36:20PM -0700, Florian Fainelli kirjoitti: > Rather than open code the i2c_designware string, utilize the newly > defined constant in i2c-designware.h. ... > static const struct mfd_cell intel_lpss_i2c_cell = { > - .name = "i2c_designware", > + .name = I2C_DESIGNWARE_NAME, > .num_resources = ARRAY_SIZE(intel_lpss_dev_resources), > .resources = intel_lpss_dev_resources, > }; We have tons of drivers that are using explicit naming, why is this case special? -- With Best Regards, Andy Shevchenko