On 16/04/24 08:54, Andi Shyti wrote: > Hi Abhinav, > >> /* Enable I2C interrupts for mpc5121 */ >> - node_ctrl = of_find_compatible_node(NULL, NULL, >> - "fsl,mpc5121-i2c-ctrl"); >> + struct device_node *node_ctrl __free(device_node) = > How have you tested this? I'm not sure I know anyone that still has a mpc5121. Maybe someone on linuxppc-dev? I did try to take the patch for a spin on my T2081RDB but I'm having some userland issues on it for some reason (unrelated to this change). The kernel boot does discover a few peripherals hanging of the I2C interface but I'm not in a position to offer up a Tested-by and I've run out of time to debug why my board is unhappy.