Hello Heiko,
On 2024-04-13 09:58, Heiko Stübner wrote:
Am Samstag, 13. April 2024, 08:44:41 CEST schrieb Dragan Simic:
On 2024-04-13 08:38, Wolfram Sang wrote:
>> Maybe it would be good to turn it into a debug message, instead of
>> simply removing it? Maybe not all client drivers handle it correctly,
>> in which case having an easy way for debugging would be beneficial.
>
> Hmm, but it still returns -ETIMEDOUT to distinguish cases?
Sure, but I think that having such an additional debug facility
can only help and save the people from adding temporary printk()s
while debugging.
Also we're talking about two lines of code, I wouldn't call that bloat
;-)
I was thinking about dev_dbg vs. removal too, but hadn't a clear
favorite.
So essentially Dragan is tipping the scale and I guess dev_dbg might be
the nicer way to go.
Yes, the code for printing the message is already there and it's only
a couple of lines, so it might be a good idea to recycle it. :)
