> > -static int aspeed_i2c_master_xfer(struct i2c_adapter *adap,
> > +static int aspeed_i2c_xfer(struct i2c_adapter *adap,
> > struct i2c_msg *msgs, int num)
>
> here the alignment goes a bi off.
Thanks, I missed this.
> > #if IS_ENABLED(CONFIG_I2C_SLAVE)
> > /* precondition: bus.lock has been acquired. */
> > -static void __aspeed_i2c_reg_slave(struct aspeed_i2c_bus *bus, u16 slave_addr)
> > +static void __aspeed_i2c_reg_target(struct aspeed_i2c_bus *bus, u16 slave_addr)
>
> We have the word master/slave forgotten here and there, but as
> we are here, /slave_addr/target_addr/
I can do this now. My plan was to convert it when I convert the whole
CONFIG_I2C_SLAVE interface. But "since we are here" can be argued.
> > static const struct i2c_algorithm aspeed_i2c_algo = {
> > - .master_xfer = aspeed_i2c_master_xfer,
> > + .xfer = aspeed_i2c_xfer,
>
> here the alignment goes a bit off.
I also wanted to fix this afterwards together with all the tab-indented
struct declarations in busses/. But maybe I better do the tab-removal
series beforehand? Would you accept such a thing?
Attachment:
signature.asc
Description: PGP signature
