Hi Andi,
On 2024/3/11 17:46, Andi Shyti wrote:
[这封邮件来自外部发件人 谨防风险]
Hi Hans,
because Mukes had questions on the v1, please do include him for
the next versions.
On Mon, Mar 11, 2024 at 04:46:55PM +0800, Hans Hu wrote:
For the case that msg->len is 0(I2C_SMBUS_QUICK), when the interrupt
occurs, it means that the access has completed, viai2c_irq_xfer()
should return 1.
The commit log is still not enough. We don't konw which patch has
introduced the error and why.
Next time, please, try to be a bit more specific, trying to anser
the questions:
- what is the problem
- how did you find out
- how you fixed
- how you tested it
But, I see that the issue was introduced here:
4b0c0569f032 ("i2c: wmt: fix a bug when thread blocked")
This patch has not been yet merged into Wolfram's tree.
Therefore, I will ask you to let this go this time and we can
take the whole series after the merge window.
Please, fix all the issues you find, including the checkpatch
warnings/errors (please keep one patch per kind of checkpatch
fix).
Last thing, please keep bug fixes separate from
features/cosmetic/refactoring. They need to be merged separately.
Does it work for you?
No other issues have been found so far.
All these suggestions you mentioned, I will pay attention to when
submitting patches in the future.
Hans,
Thanks
