Hello Andi,
On Fri Mar 8, 2024 at 12:11 AM CET, Andi Shyti wrote:
> Hi Theo,
>
> ...
>
> > +static inline u8 nmk_i2c_readb(const struct nmk_i2c_dev *priv,
> > + unsigned long reg)
> > +{
> > + if (priv->has_32b_bus)
> > + return readl(priv->virtbase + reg);
> > + else
> > + return readb(priv->virtbase + reg);
> > +}
>
> you forgot to remove the else... not a problem, it's coherent
> with its writeb counterpart.
Yes I enjoy symmetry. :-)
[...]
> Looks good!
>
> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Thanks Andi! Any chance of seeing this series queued for v6.9?
Regards,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
