Re: [PATCH] Input: bma150: remove I2C_CLASS_HWMON from drivers w/o detect and address_list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27.01.2024 16:18, Heiner Kallweit wrote:
> Class-based I2C probing requires detect() and address_list to be
> set in the I2C client driver, see checks in i2c_detect().
> It's misleading to declare I2C_CLASS_HWMON support if this
> precondition isn't met.
> 
Any feedback here? Should this better go through the I2C tree?

> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> ---
>  drivers/input/misc/bma150.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
> index 0fb4cc628..22feaa8c1 100644
> --- a/drivers/input/misc/bma150.c
> +++ b/drivers/input/misc/bma150.c
> @@ -549,7 +549,6 @@ static struct i2c_driver bma150_driver = {
>  		.name	= BMA150_DRIVER,
>  		.pm	= &bma150_pm,
>  	},
> -	.class		= I2C_CLASS_HWMON,
>  	.id_table	= bma150_id,
>  	.probe		= bma150_probe,
>  	.remove		= bma150_remove,





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux