Hi Theo, On Thu, Feb 29, 2024 at 07:10:51PM +0100, Théo Lebrun wrote: > Disambiguate the usage of dev as a variable name; it is usually best to > keep it reserved for struct device pointers. Avoid having multiple > names for the same struct pointer (previously: dev, nmk, nmk_i2c). just a nitpick here: this patch does also some small style fixes. Could you please mention them in the commit log in your v3? > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> In any case, Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> Thanks, Andi