On Fri, Feb 23, 2024 at 4:34 PM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > Hi Rob, > > > > * In the schema, "clock-frequency" has a minimum of 1kHz and a maximum > > > of 3MHz. Why? The specs do not say anything about a minimum freq and > > > fastest speed mentioned in the docs is 5Mhz (Ultra fast mode). > > > > IIRC, the high speed mode originally topped out at 3MHz. I guess > > that's been revised. > > Hs-mode has a max of 3.4MHz... > > > > > We can drop the minimum. > > ... but I see you changed min/max now to 1/5000000. That's what I would > have suggested as well. > > > > > * new binding "i2c-scl-clk-low-timeout-us" has a description which I do > > > not understand. What is a waiting state? > > > > Shrug. May have to look at the MPC h/w that uses the property. > > I will also have another look. My gut feeling is that the binding is > okay, only the description might need an update. > > > > > > > * new binding "no-detect" is broken. At the least, it should be named > > > something like "bus-fully-described" and then the OS can decide to > > > leave out auto-detection mechanisms. If you are interested in the > > > latter, you can simply disable class based instantiation on the host > > > controller. No need to describe this in DT. > > > > I've reverted the property now. > > Cool, thanks! I don't think there's anything else to discuss on this patch, can I get your ack? Rob
