Hi Wolfram, On Wed, Feb 21, 2024 at 11:54:54PM +0100, Wolfram Sang wrote: > On Wed, Feb 21, 2024 at 09:58:23PM +0100, Andi Shyti wrote: > > Hi Wolfram and Corey, > > > > On Wed, Feb 21, 2024 at 08:27:13PM +0100, Wolfram Sang wrote: > > > From: Corey Minyard <minyard@xxxxxxx> > > > > > > When being a target, NAK from the controller means that all bytes have > > > been transferred. So, the last byte needs also to be marked as > > > 'processed'. Otherwise index registers of backends may not increase. > > > > > > Signed-off-by: Corey Minyard <minyard@xxxxxxx> > > > Tested-by: Andrew Manley <andrew.manley@xxxxxxxxxxxxxxx> > > > Reviewed-by: Andrew Manley <andrew.manley@xxxxxxxxxxxxxxx> > > > Reviewed-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> > > > [wsa: fixed comment and commit message to properly describe the case] > > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > > > is this a fix? > > In deed, it is: > > Fixes: f7414cd6923f ("i2c: imx: support slave mode for imx I2C driver") Looks good :) Are any action needed on my side? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |