Dear Patrick,
Thank you very much for sending your first Linux kernel contribution! I
have some nitpicks, you could address with `git commit --amend`, and
resend as v2 with `git format-patch -v2 …`.
Linux patches are normally prefixed by the subsystem. `git log --oneline
drivers/i2c/busses/i2c-i801.c` should give a hint.
Am 18.02.24 um 19:03 schrieb Patrick Höhn:
Signed-off-by: Patrick Höhn <hoehnp@xxxxxx>
I personally prefer elaborate commit messages despite most can be
deduced from the diff. I also like a description of the test system, in
case of a laptop the system firmware version you tested with would be
great to have.
---
drivers/i2c/busses/i2c-i801.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 2c36b36d7d51..ba699db27f58 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -1234,6 +1234,7 @@ static const struct {
{ "Vostro V131", 0x1d },
{ "Vostro 5568", 0x29 },
{ "XPS 15 7590", 0x29 },
+ { "Precision M6800", 0x29 },
It would be great if you sorted this lexicographically.
};
static void register_dell_lis3lv02d_i2c_device(struct i801_priv *priv)
I am looking forward to the updated version. If I can help in any way,
please don’t hesitate to ask.
Kind regards,
Paul
