On 2/16/24 02:09, Krzysztof Kozlowski wrote:
On 15/02/2024 23:07, Eddie James wrote:
AST2700 requires a few bits set differently in the OPB retry
counter register, so add some match data and set the register
accordingly.
Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx>
---
drivers/fsi/fsi-master-aspeed.c | 28 +++++++++++++++++++++++++---
+
static const struct of_device_id fsi_master_aspeed_match[] = {
- { .compatible = "aspeed,ast2600-fsi-master" },
+ {
+ .compatible = "aspeed,ast2600-fsi-master",
+ .data = &fsi_master_ast2600_data,
+ },
+ {
+ .compatible = "aspeed,ast2700-fsi-master",
Undocumented. Really, you do not have checkpatch in IBM?
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
I ran checkpatch. There are several FSI drivers with undocumented
compatible strings, and the Aspeed master documentation isn't in yaml
format, so that would require an update too. Therefore I ignored the
warning - my mistake. I will document it in v2.
Best regards,
Krzysztof
