Hi Hans, > > On 05/01/2024 08:51, Hans Hu wrote: > > > v5->v7: > > > nothing changed. > > > v4->v5: > > > add previous prototype 'static' for wmt_i2c_init(). > > > Link: https://lore.kernel.org/all/ZYx0VPVmyQhtG+B9@shikoro/1-a.txt > > Why there is only changelog and no commit msg? Changelog goes usually > > under ---, especially if it is quite non-informative... > > Commit msg comes after changelog. Yes, I should have put > commit msg at the beginning. Other patches also have this > problem. Adjustments will be made at the next submission. While it can be convenient to include the changelog in each patch from the reviewers perspective, having it all in patch 0 is sufficient. Personally, I'm not in favour of adding the changelog to the commit log, even though it's a practice common in many communities. However, I'm open to whatever approach you select, provided there is consistency. If you decide to keep the changelog, consider placing it at the end of the commit message, right before the tag section. Andi
