Re: [PATCH] i2c: designware: Revert recent changes to i2c_dw_probe_lock_support()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/16/24 00:44, Kim Phillips wrote:
On 1/15/24 3:16 PM, Kim Phillips wrote:
On 1/12/24 2:13 AM, Jarkko Nikula wrote:
On 1/11/24 19:56, Kim Phillips wrote:
[    6.245173] i2c_designware AMDI0010:00: Unknown Synopsys component type: 0xffffffff

This has puzzled me all the time since I'm unable to see which one of Andy's patches could cause it. However controller is clearly powered down since DW_IC_COMP_TYPE register reads 0xffffffff.

Just FYI, that message is apparently 'normal' as, e.g., a stable v6.4
based tree emits it, but it doesn't crash because of it:

Ah, makes sense. I understood from Narasimhan's earlier mail vanilla doesn't show it and that made me confused.

So I just tested checking out bd466a892612, and indeed it produces
the stacktrace.  Prior to that commit is v6.7-rc3, which boots fine.
So right now I'm suspecting bd466a892612 is to blame for the stacktrace.

This also makes most sense to me and was my first guess. I let Andy to look at more deeply does my speculation about runtime PM being active in parallel with post probe code since before his commit driver disabled the runtime PM before returning from probe.

Now if after that commit oops doesn't occur always it will easily misguide in bisecting and can lead to random results. Those are very hard to track sometimes. Good that you found this issue very immediately when code went to linux-next!




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux