Re: [PATCH 04/14] mux: mmio: Add resume support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 04/14] mux: mmio: Add resume support
From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Date: Mon, 15 Jan 2024 22:05:52 +0200
Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>, Bartosz Golaszewski <brgl@xxxxxxxx>, Andy Shevchenko <andy@xxxxxxxxxx>, Tony Lindgren <tony@xxxxxxxxxxx>, Haojian Zhuang <haojian.zhuang@xxxxxxxxxx>, Vignesh R <vigneshr@xxxxxx>, Aaro Koskinen <aaro.koskinen@xxxxxx>, Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx>, Andi Shyti <andi.shyti@xxxxxxxxxx>, Peter Rosin <peda@xxxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Kishon Vijay Abraham I <kishon@xxxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, Tom Joseph <tjoseph@xxxxxxxxxxx>, Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, linux-gpio@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-phy@xxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, gregory.clement@xxxxxxxxxxx, theo.lebrun@xxxxxxxxxxx, thomas.petazzoni@xxxxxxxxxxx, u-kumar1@xxxxxx
In-reply-to: <20240102-j7200-pcie-s2r-v1-4-84e55da52400@bootlin.com>
References: <20240102-j7200-pcie-s2r-v1-0-84e55da52400@bootlin.com> <20240102-j7200-pcie-s2r-v1-4-84e55da52400@bootlin.com>

On Mon, Jan 15, 2024 at 6:16 PM Thomas Richard
<thomas.richard@xxxxxxxxxxx> wrote:
>
> From: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
>
> Implement resume support

Why?

...

> +#ifdef CONFIG_PM

No ifdeffery, use proper macros.

...

> +                       dev_err(dev, "control %u: error restoring mux: %d\n", i, ret);

Won't anything go wrong and spam the log buffer?

-- 
With Best Regards,
Andy Shevchenko

References:
- [PATCH 00/14] Add suspend to ram support for PCIe on J7200
  - From: Thomas Richard
- [PATCH 04/14] mux: mmio: Add resume support
  - From: Thomas Richard

Prev by Date: Re: [PATCH 03/14] i2c: omap: wakeup the controller during suspend callback
Next by Date: Re: [PATCH 13/14] PCI: j721e: move reset GPIO to device struct
Previous by thread: [PATCH 04/14] mux: mmio: Add resume support
Next by thread: Re: [PATCH 04/14] mux: mmio: Add resume support
Index(es):
- Date
- Thread

[Index of Archives] [Linux GPIO] [Linux SPI] [Linux Hardward Monitoring] [LM Sensors] [Linux USB Devel] [Linux Media] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]