Hi Hans, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.7] [cannot apply to wsa/i2c/for-next next-20240108] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Hans-de-Goede/platform-x86-dell-smo8800-Only-load-on-Dell-laptops/20231225-152720 base: linus/master patch link: https://lore.kernel.org/r/20231224213629.395741-6-hdegoede%40redhat.com patch subject: [PATCH 5/6] platform/x86: dell-smo8800: Instantiate an i2c_client for the IIO st_accel driver config: i386-randconfig-003-20240106 (https://download.01.org/0day-ci/archive/20240109/202401090941.FHkrtPXf-lkp@xxxxxxxxx/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240109/202401090941.FHkrtPXf-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202401090941.FHkrtPXf-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): ld: drivers/platform/x86/dell/dell-smo8800.o: in function `smo8800_remove': drivers/platform/x86/dell/dell-smo8800.c:358: undefined reference to `i2c_unregister_device' ld: drivers/platform/x86/dell/dell-smo8800.c:358: undefined reference to `i2c_unregister_device' ld: drivers/platform/x86/dell/dell-smo8800.o: in function `smo8800_instantiate_i2c_client': drivers/platform/x86/dell/dell-smo8800.c:243: undefined reference to `i2c_bus_type' ld: drivers/platform/x86/dell/dell-smo8800.c:286: undefined reference to `i2c_put_adapter' ld: drivers/platform/x86/dell/dell-smo8800.o: in function `smo8800_detect_accel': >> drivers/platform/x86/dell/dell-smo8800.c:170: undefined reference to `i2c_smbus_xfer' ld: drivers/platform/x86/dell/dell-smo8800.o: in function `smo8800_instantiate_i2c_client': drivers/platform/x86/dell/dell-smo8800.c:276: undefined reference to `i2c_new_client_device' ld: drivers/platform/x86/dell/dell-smo8800.o: in function `smo8800_probe': drivers/platform/x86/dell/dell-smo8800.c:345: undefined reference to `i2c_unregister_device' ld: drivers/platform/x86/dell/dell-smo8800.o: in function `smo8800_find_i801': drivers/platform/x86/dell/dell-smo8800.c:131: undefined reference to `i2c_verify_adapter' ld: drivers/platform/x86/dell/dell-smo8800.c:145: undefined reference to `i2c_get_adapter' vim +170 drivers/platform/x86/dell/dell-smo8800.c 161 162 static int smo8800_detect_accel(struct smo8800_device *smo8800, 163 struct i2c_adapter *adap, u8 addr, 164 struct i2c_board_info *info) 165 { 166 union i2c_smbus_data smbus_data; 167 const char *type; 168 int err; 169 > 170 err = i2c_smbus_xfer(adap, addr, 0, I2C_SMBUS_READ, LIS3_WHO_AM_I, 171 I2C_SMBUS_BYTE_DATA, &smbus_data); 172 if (err < 0) { 173 dev_warn(smo8800->dev, "Failed to read who-am-i register: %d\n", err); 174 return err; 175 } 176 177 /* 178 * These who-am-i register mappings to model strings have been 179 * taken from the old /dev/freefall chardev and joystick driver: 180 * drivers/misc/lis3lv02d/lis3lv02d.c 181 */ 182 switch (smbus_data.byte) { 183 case 0x32: 184 type = "lis331dlh"; 185 break; 186 case 0x33: 187 type = "lis2de12"; /* LIS3DC / HP3DC in drivers/misc/lis3lv02d/lis3lv02d.c */ 188 break; 189 case 0x3a: 190 type = "lis3lv02dl_accel"; 191 break; 192 case 0x3b: 193 type = "lis302dl"; 194 break; 195 default: 196 dev_warn(smo8800->dev, "Unknown who-am-i register value 0x%02x\n", 197 smbus_data.byte); 198 return -ENODEV; 199 } 200 201 strscpy(info->type, type, I2C_NAME_SIZE); 202 info->addr = addr; 203 info->irq = smo8800->irq; 204 info->swnode = &smo8800_accel_node; 205 return 0; 206 } 207 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
