On Wed, Dec 20, 2023 at 04:54:15PM -0700, Mark Hasemeyer wrote: > Other information besides wake capability can be provided about GPIO > IRQs such as triggering, polarity, and sharability. Use resource flags > to provide this information to the caller if they want it. > > This should keep the API more robust over time as flags are added, > modified, or removed. It also more closely matches acpi_irq_get() which > take a resource as an argument. > > Rename the function to acpi_dev_get_gpio_irq_resource() to better > describe the function's new behavior. ... > + *r = DEFINE_RES_IRQ(irq); > + r->flags = acpi_dev_irq_flags(info.triggering, info.polarity, > + info.shareable, info.wake_capable); Looking at this I am wondering if we can actually to have unsigned long irq_flags; ... irq_flags = acpi_dev_irq_flags(info.triggering, info.polarity, info.shareable, info.wake_capable); *r = DEFINE_RES_NAMED(irq, 1, NULL, irq_flags); as we don't need to duplicate IORESOURCE_IRQ. -- With Best Regards, Andy Shevchenko
