On Tue, 2023-12-12 at 13:09 +1030, Joel Stanley wrote: > On Mon, 11 Dec 2023 at 20:52, Quan Nguyen <quan@xxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > This series consists of two patches to handle the below issues observed > > when testing with slave mode: > > + The coalesced stop condition with the start conditions > > + Early ack'ed of Tx done (ACK and NAK) causing "Unexpected Ack on > > read request". > > Looks good. I've reached out to a few people who use slave mode to ask > for review and testing on hardware. As long as they don't come back > with issues, we should get this merged and backported to stable. > > Reviewed-by: Joel Stanley <joel@xxxxxxxxx> I've dropped a build with the patches onto an AST2600 EVB and lightly exercised the affected paths using NVMe-MI over MCTP to a Micron 7450. Tested-by: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx> Andrew