Re: [PATCH v4 24/24] i2c: designware: Fix spelling and other issues in the comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

[...]

> @@ -210,12 +210,12 @@ static void psp_release_i2c_bus(void)
>  {
>  	mutex_lock(&psp_i2c_access_mutex);
>  
> -	/* Return early if mailbox was malfunctional */
> +	/* Return early if mailbox was malfunctioned */

has malfunctioned?

>  	if (psp_i2c_mbox_fail)
>  		goto cleanup;
>  
>  	/*
> -	 * If we are last owner of PSP semaphore, need to release aribtration
> +	 * If we are last owner of PSP semaphore, need to release arbitration
>  	 * via mailbox.
>  	 */

as we are at this, perhaps we can add some articles and pronouns
to improve the grammar:

	/*
	 * If we are the last owner of the PSP semaphore, we need to release
	 * arbitration via the mailbox
	 */

Rest looks good.

Thanks,
Andi




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux