Hi Andy, On Mon, Nov 20, 2023 at 04:42:00PM +0200, Andy Shevchenko wrote: > We have the same (*) PM ops in the PCI and plaform drivers. > Instead, consolidate that PM ops under exported variable and > deduplicate them. > > *) > With the subtle ACPI and P-Unit behaviour differences in PCI case. > But this is not a problem as for ACPI we need to take care of the > P-Unit semaphore anyway and calling PM ops for ACPI makes sense as > it might provide specific operation regions in (however there are > no known devices on market that are using it with PCI enabled I2C). > Note, the clocks are not in use in the PCI case. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> The comment in the "prepare" function is a bit cryptic, though it took me some time to disentangle from the double/triple negations :-) Thanks, Andi
