Hello, brgl@xxxxxxxx wrote on Wed, 29 Nov 2023 10:10:28 +0100: > On Mon, Nov 27, 2023 at 5:46 PM Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote: > > > > [snip] > > > > > I dropped the backward compatibility since this is a new driver not > > having to deal with it. The old and the new driver can not be used by > > the same kernel config. So it is either using the MTD eeprom driver > > supporting partitioning and NVMEM or the older one which does not > > support partitioning but keeps the backward compatibility. > > > > Comments and suggestions are very welcome :) > > I skimmed through the code. Nothing obviously wrong. What I would > suggest - if we're going to have two at24 drivers - is a lot more code > reuse. I dislike the idea of having basically the same code in two > places in the kernel and having to fix bugs in both. Agreed. > Though if I'm being honest - I would prefer a single driver with > backwards compatibility. Have you estimated the effort it would take > to abstract both nvmem and mtd? Also agreed :-) Thanks, Miquèl
