On Wed, Nov 15, 2023 at 02:08:10PM +0200, Jarkko Nikula wrote:
> On 11/10/23 20:11, Andy Shevchenko wrote:
...
> > @@ -360,9 +354,6 @@ static void i2c_dw_pci_remove(struct pci_dev *pdev)
> > pm_runtime_forbid(&pdev->dev);
> > pm_runtime_get_noresume(&pdev->dev);
> > -
> > - devm_free_irq(&pdev->dev, dev->irq, dev);
> > - pci_free_irq_vectors(pdev);
>
> Instead of commit 21aa3983d619 I guess this patch is more around my commit
> 9be8bc4dd617 ("i2c: designware-pci: Fix BUG_ON during device removal")?
No, this one exactly what it says. Your patch is the side effect of the above
mentioned change.
> But
> still I don't think it qualifies Fixes tag?
Up to you, I can remove the fixes tag altogether, but it has the correct
commit ID there.
> I was curious to see would this patch bring back above BUG_ON and
> fortunately not (rmmod/modprobe i2c_designware_pci on MSI enabled
> instance):-)
How? PCI clean up will happen on the level of pcim_enable_device(),
i.e. quite after the IRQ will be freed.
--
With Best Regards,
Andy Shevchenko
