On Wed, 8 Nov 2023 at 11:44, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > While re-indenting the first enum, put also axis,artpec8-dw-mshc in > alphabetical order. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Kind regards Uffe > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/mmc/samsung,exynos-dw-mshc.yaml | 25 ++++++++++++------- > 1 file changed, 16 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml > index 6ee78a38bd74..5fe65795f796 100644 > --- a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml > +++ b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml > @@ -14,15 +14,22 @@ maintainers: > > properties: > compatible: > - enum: > - - samsung,exynos4210-dw-mshc > - - samsung,exynos4412-dw-mshc > - - samsung,exynos5250-dw-mshc > - - samsung,exynos5420-dw-mshc > - - samsung,exynos5420-dw-mshc-smu > - - samsung,exynos7-dw-mshc > - - samsung,exynos7-dw-mshc-smu > - - axis,artpec8-dw-mshc > + oneOf: > + - enum: > + - axis,artpec8-dw-mshc > + - samsung,exynos4210-dw-mshc > + - samsung,exynos4412-dw-mshc > + - samsung,exynos5250-dw-mshc > + - samsung,exynos5420-dw-mshc > + - samsung,exynos5420-dw-mshc-smu > + - samsung,exynos7-dw-mshc > + - samsung,exynos7-dw-mshc-smu > + - items: > + - enum: > + - samsung,exynos5433-dw-mshc-smu > + - samsung,exynos7885-dw-mshc-smu > + - samsung,exynos850-dw-mshc-smu > + - const: samsung,exynos7-dw-mshc-smu > > reg: > maxItems: 1 > -- > 2.34.1 >
