Re: [PATCH v2 04/12] i2c: designware: Drop return value from dw_i2c_of_configure()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 04/12] i2c: designware: Drop return value from dw_i2c_of_configure()
From: Andi Shyti <andi.shyti@xxxxxxxxxx>
Date: Thu, 9 Nov 2023 21:36:18 +0100
Cc: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Mario Limonciello <mario.limonciello@xxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxx>, linux-i2c@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>, Jan Dabros <jsd@xxxxxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>
In-reply-to: <20231109182823.3531846-5-andriy.shevchenko@linux.intel.com>
References: <20231109182823.3531846-1-andriy.shevchenko@linux.intel.com> <20231109182823.3531846-5-andriy.shevchenko@linux.intel.com>

Hi Andy,

On Thu, Nov 09, 2023 at 08:19:14PM +0200, Andy Shevchenko wrote:
> dw_i2c_of_configure() is called without checking of the returned
> value, hence just drop it by converting to void.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

Andi

References:
- [PATCH v2 00/12] i2c: designware: code consolidation & cleanups
  - From: Andy Shevchenko
- [PATCH v2 04/12] i2c: designware: Drop return value from dw_i2c_of_configure()
  - From: Andy Shevchenko

Prev by Date: Re: [PATCH v2 03/12] i2c: designware: Drop return value from i2c_dw_acpi_configure()
Next by Date: Re: [PATCH v2 05/12] i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure()
Previous by thread: [PATCH v2 04/12] i2c: designware: Drop return value from dw_i2c_of_configure()
Next by thread: [PATCH v2 10/12] i2c: designware: Fix spelling and other issues in the comments
Index(es):
- Date
- Thread

[Index of Archives] [Linux GPIO] [Linux SPI] [Linux Hardward Monitoring] [LM Sensors] [Linux USB Devel] [Linux Media] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]