On 26.10.2023 19:37, Wolfram Sang wrote:
> Hi Heiner!
>
>> With removal of the legacy eeprom driver the only i2c client device
>> driver with I2C_CLASS_DDC is gone, so it's time to mark I2C_CLASS_DDC
>> as deprecated.
>
> OK, but I will need to wait until the eeprom-removal hits mainline.
>
>> Use pr_warn_once, because graphics adapters can have several i2c
>> busses and we may see the warning multiple times otherwise.
>>
>> Note:
>> Driver staging/olpc_dcon declares support for classes HWMON and DDC,
>> but only HWMON is used with the scx200_acb adapter driver on olpc
>> devices.
>
> And why don't we remove its DDC declaration here in this patch?
>
Both changes should reach mainline in the next days.
0210a684cdb2 ("staging: olpc_dcon: Remove I2C_CLASS_DDC support")
0113a99b8a75 ("eeprom: Remove deprecated legacy eeprom driver")
I reactivated my rudimentary Coccinelle skills and think I'll prepare
a series that removes definition of I2C_CLASS_DDC and all its users.
Means you can drop the patch introducing a depreciation warning.
> Thanks for cleaning this up!
>
> Regards,
>
> Wolfram
>
Heiner
