Hi Nick, > > > The i2c-amd756-s4882 and i2c-nforce2-s4985 muxing pseudo-drivers were > > > written at a time when the i2c core did not support muxing. They are > > > essentially board-specific hacks. If we had to add support for these > > > boards today, we would implement it in a completely different way. > > > > > > These Tyan server boards are 18 years old by now, so I very much doubt > > > any of these is still running today. So let's just drop this clumsy > > > code. If anyone really still needs this support and complains, I'll > > > rewrite it in a proper way on top of i2c-mux. > > > > > > This also fixes the following warnings: > > > drivers/i2c/busses/i2c-amd756.c:286:20: warning: symbol 'amd756_smbus' was not declared. Should it be static? > > > drivers/i2c/busses/i2c-nforce2.c:123:20: warning: symbol 'nforce2_smbus' was not declared. Should it be static? > > > > > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> > > > Acked-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > Cc: Andi Shyti <andi.shyti@xxxxxxxxxx> > > > > I think I commented here that I had double thoughts on this. I > > Please consider using an explicit NACK if you feel strongly. My > reading of your comment was that you did not feel strongly. I'm not strong... > > said that on one hand I like the cleanup, but on the other what's > > wrong keeping them here? > > We can always resurrect the driver if someone complains, which I > believe there's prior art for. Nothing is ever truly dead with git. > "That is not dead which can eternal lie, and with strange aeons even > death may die" or something. > > > > > Maybe someone is still using these devices. > > > > BTW, do you really have them? > > I think Wolfram wrote the drivers. If he's the sole author and stuck > with maintaining these, I can totally see a maintainer saying "it's > time to put this old dog down." ... for this reason. The maintainer/author of the driver might feel this being a bit of a heavy burden to carry around. I personally prefer the drivers to stay, but I'm not going to nack this patch and I'm not going to ack it either. In any case I'm not blocking it. Thanks, Andi
