Re: [PATCH] i2c: xiic: Correct return value check for xiic_reinit()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniel,

[...]

> @@ -710,7 +710,7 @@ static irqreturn_t xiic_process(int irq, void *dev_id)
>  		 * reset the IP instead of just flush fifos
>  		 */
>  		ret = xiic_reinit(i2c);
> -		if (!ret)
> +		if (ret < 0)
>  			dev_dbg(i2c->adap.dev.parent, "reinit failed\n");

this should be a dev_warn(), but it's anyway out of the scope of
this patch.

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> 

Andi



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux