Re: [PATCH] i2c: gpio: remove error checks with debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

[...]

> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
> index e5a5b9e8bf2c..fb35a75fe0e3 100644
> --- a/drivers/i2c/busses/i2c-gpio.c
> +++ b/drivers/i2c/busses/i2c-gpio.c
> @@ -263,15 +263,10 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev)
>  	 * 'fault-injector' dir there. Until then, we have a global dir with
>  	 * all adapters as subdirs.
>  	 */
> -	if (!i2c_gpio_debug_dir) {
> +	if (!i2c_gpio_debug_dir)
>  		i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL);
> -		if (!i2c_gpio_debug_dir)
> -			return;
> -	}
>  
>  	priv->debug_dir = debugfs_create_dir(pdev->name, i2c_gpio_debug_dir);
> -	if (!priv->debug_dir)
> -		return;

nice... this reminds me of some more cleanups that needs to be
done elsewhere.

Another good thing that comes out from this patch is that if a
debgufs entry is not created it's not a big deal and we shouldn't
return but move ahead with the function execution.

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> 

Andi



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux