Hi Wolfram, > > > { .compatible = "renesas,i2c-r8a7794", .data = (void *)I2C_RCAR_GEN2 }, > > > { .compatible = "renesas,i2c-r8a7795", .data = (void *)I2C_RCAR_GEN3 }, > > > { .compatible = "renesas,i2c-r8a7796", .data = (void *)I2C_RCAR_GEN3 }, > > > + /* S4 has no FM+ bit */ > > > + { .compatible = "renesas,i2c-r8a779f0", .data = (void *)I2C_RCAR_GEN3 }, > > > > is this I2C_RCAR_GEN3 or I2C_RCAR_GEN4? > > Technically, it is Gen4. But its I2C controller behaves like Gen3. This > is why it has a seperate entry to avoid the generic Gen4 fallback... > > > > - { .compatible = "renesas,rcar-gen4-i2c", .data = (void *)I2C_RCAR_GEN3 }, > > > + { .compatible = "renesas,rcar-gen4-i2c", .data = (void *)I2C_RCAR_GEN4 }, > > ... here. got it... I just wanted to be sure... thanks! Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> Andi