> From: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> Hi,
>
> On 9/4/23 07:44, Wentong Wu wrote:
> > Implements the USB part of Intel USB-I2C/GPIO/SPI adapter device named
> > "La Jolla Cove Adapter" (LJCA).
> >
> > The communication between the various LJCA module drivers and the
> > hardware will be muxed/demuxed by this driver. Three modules ( I2C,
> > GPIO, and SPI) are supported currently.
> >
> > Each sub-module of LJCA device is identified by type field within the
> > LJCA message header.
> >
> > The sub-modules of LJCA can use ljca_transfer() to issue a transfer
> > between host and hardware. And ljca_register_event_cb is exported to
> > LJCA sub-module drivers for hardware event subscription.
> >
> > The minimum code in ASL that covers this board is Scope
> > (\_SB.PCI0.DWC3.RHUB.HS01)
> > {
> > Device (GPIO)
> > {
> > Name (_ADR, Zero)
> > Name (_STA, 0x0F)
> > }
> >
> > Device (I2C)
> > {
> > Name (_ADR, One)
> > Name (_STA, 0x0F)
> > }
> >
> > Device (SPI)
> > {
> > Name (_ADR, 0x02)
> > Name (_STA, 0x0F)
> > }
> > }
> >
> > Signed-off-by: Wentong Wu <wentong.wu@xxxxxxxxx>
> > Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
> > Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > ---
> > +
> > +static int ljca_match_device_ids(struct acpi_device *adev, void
> > +*data) {
> > + struct ljca_match_ids_walk_data *wd = data;
> > + const char *uid = acpi_device_uid(adev);
> > +
> > + if (acpi_match_device_ids(adev, wd->ids))
> > + return 0;
> > +
> > + if (!wd->uid)
> > + goto match;
> > +
> > + if (!uid)
> > + uid = "0";
> > + else
> > + uid = memchr(uid, wd->uid[0], strlen(uid));
>
> Note this line can be simplified to:
>
> uid = strchr(uid, wd->uid[0]);
Ack, this will be included in next version, thanks.
BR,
Wentong
>
> Regards,
>
> Hans
