On Fri, 1 Sep 2023 19:02:13 +0200, Heiner Kallweit wrote:
> On 01.09.2023 18:44, Jean Delvare wrote:
> > Hi Heiner,
> >
> > On Tue, 29 Aug 2023 08:25:23 +0200, Heiner Kallweit wrote:
> >> Currently we set SMBHSTCNT_LAST_BYTE only after the host has started
> >> receiving the last byte. If we get e.g. preempted before setting
> >> SMBHSTCNT_LAST_BYTE, the host may be finished with receiving the byte
> >> before SMBHSTCNT_LAST_BYTE is set.
> >> Therefore change the code to set SMBHSTCNT_LAST_BYTE before writing
> >> SMBHSTSTS_BYTE_DONE for the byte before the last byte. Now the code
> >> is also consistent with what we do in i801_isr_byte_done().
> >>
> >> Fixes: efa3cb15ad8b ("i2c-i801: Refactor use of LAST_BYTE in i801_block_transaction_byte_by_byte")
> >
> > I don't think this is true. This patch refactored the code but didn't
> > change the logic. The bug existed before already. As far as I see, the
> > race condition already existed when the kernel switched to git, so
> > there's no point in having a Fixes statement.
>
> Shall we go with the patch as-is or do you think it's better to resubmit
> w/o the Fixes tag?
Please resubmit, for the sake of correctness and to be fair to Daniel.
--
Jean Delvare
SUSE L3 Support
