Hi Hans, > Recently I plan to submit one SMBus driver for Zhaoxin platform. > I studied the existing SMBus drivers, including i2c-viapro.c, > i2c-i801.c, and i2c-piix4.c. These driver's register layout looks > similar, and the implementation of their .smbus_xfer callback > functions is similar too. > > Zhaoxin SMBus also uses some of the same design scheme > (follow VIA's design IP). Then, should I create *-common.{c,h} > for these dirvers? Or keep the register layout and .smbus_xfer's > implementation in my own driver? Or any other suggestion? > > Look forward to your suggestions! Sorry for the late reply, I see that you already sent the patches, will check them. Andi