Re: [PATCH v2] i2c: stm32f7: Add atomic_xfer method to driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alain,

> On 16 Aug 2023, at 09.02, Sean Nyekjaer <sean@xxxxxxxxxx> wrote:
> 

[ … ]

>>> _dev {
>>> u32 dnf_dt;
>>> u32 dnf;
>>> struct stm32f7_i2c_alert *alert;
>>> + bool atomic;
>> 
>> I am wondering if this atomic really needs to be within the struct.
>> It could well be given as last arg of stm32f7_i2c_xfer_core and
>> stm32f7_i2c_xfer functions.
> 
> Agree.

Scratch that…
The atomic was included in the struct because it’s also used in the isr function, as the isr function is calling stm32f7_i2c_xfer_msg()

/Sean





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux