On Mon, Aug 14, 2023 at 02:52:52PM -0700, Dmitry Torokhov wrote: > Switch the driver to use newly added "data" pointer in i2c_device_id and > introduce struct eeprom_chip to describe chip's characteristics instead > of cramming it all into an unisigned long and then decipher. ... > - const struct i2c_device_id *id = i2c_client_get_device_id(client); > + const struct i2c_device_id *id; > + id = i2c_client_get_device_id(client); > + if (!id) > + return -EINVAL; Unneeded piece of change. -- With Best Regards, Andy Shevchenko