Hi Ruan,
On Mon, Jul 31, 2023 at 07:27:55PM +0800, Ruan Jinjie wrote:
> There is no possible for platform_get_irq() to return 0,
> and the return value of platform_get_irq() is more sensible
> to show the error reason.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@xxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index e897d9101434..579b30581725 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -2121,12 +2121,12 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
> phy_addr = (dma_addr_t)res->start;
>
> irq_event = platform_get_irq(pdev, 0);
> - if (irq_event <= 0)
> - return irq_event ? : -ENOENT;
> + if (irq_event < 0)
> + return irq_event;
>
> irq_error = platform_get_irq(pdev, 1);
> - if (irq_error <= 0)
> - return irq_error ? : -ENOENT;
> + if (irq_error < 0)
> + return irq_error;
Correct, from patch ce753ad1549cbe ("platform: finally disallow
IRQ0 in platform_get_irq() and its ilk") this check is already
done inside platform_get_irq();
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Andi
>
> i2c_dev->wakeup_src = of_property_read_bool(pdev->dev.of_node,
> "wakeup-source");
> --
> 2.34.1
>
