Hi Carlos, On Wed, Jul 26, 2023 at 05:22:38PM +0800, carlos.song@xxxxxxx wrote: > From: Carlos Song <carlos.song@xxxxxxx> > > On MX8X platforms, the default clock rate is 0 if without explicit > clock setting in dts nodes. I2c can't work when i2c peripheral clk > rate is 0. > > Add a i2c peripheral clk rate check before configuring the clock > register. When i2c peripheral clk rate is 0 and directly return > -EINVAL. > > Signed-off-by: Carlos Song <carlos.song@xxxxxxx> you are missing here: Acked-by: Dong Aisheng <Aisheng.dong@xxxxxxx> You can also add: Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> (no need to resend) Thanks! Andi