Hi Andy,
On Tue, Jul 25, 2023 at 05:30:15PM +0300, Andy Shevchenko wrote:
> Instead of checking in callers, move the call to the callee.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-designware-common.c | 11 +++++++++--
> drivers/i2c/busses/i2c-designware-pcidrv.c | 3 +--
> drivers/i2c/busses/i2c-designware-platdrv.c | 3 +--
> 3 files changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c
> index cdd8c67d9129..683f7a9beb46 100644
> --- a/drivers/i2c/busses/i2c-designware-common.c
> +++ b/drivers/i2c/busses/i2c-designware-common.c
> @@ -255,9 +255,8 @@ static void i2c_dw_acpi_params(struct device *device, char method[],
> kfree(buf.pointer);
> }
>
> -int i2c_dw_acpi_configure(struct device *device)
> +static void i2c_dw_acpi_do_configure(struct dw_i2c_dev *dev, struct device *device)
> {
> - struct dw_i2c_dev *dev = dev_get_drvdata(device);
> struct i2c_timings *t = &dev->timings;
> u32 ss_ht = 0, fp_ht = 0, hs_ht = 0, fs_ht = 0;
>
> @@ -285,6 +284,14 @@ int i2c_dw_acpi_configure(struct device *device)
> dev->sda_hold_time = fs_ht;
> break;
> }
> +}
> +
> +int i2c_dw_acpi_configure(struct device *device)
I was about to ask you why are we keeping this int, but then I
saw that you are making it void in the next patch :)
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Andi
