Hi Minje,
On Wed, Jul 12, 2023 at 07:22:22PM +0800, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return.
>
> Signed-off-by: Minjie Du <duminjie@xxxxxxxx>
>
> v1-v2:
> Fix judge typo.
Please next time add the changelog after the "---" section.
You will also need:
Fixes: 14911c6f48ec ("i2c: gpio: add fault injector")
Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx> # v4.16+
Said that:
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Andi
> ---
> drivers/i2c/busses/i2c-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
> index e5a5b9e8b..545927b96 100644
> --- a/drivers/i2c/busses/i2c-gpio.c
> +++ b/drivers/i2c/busses/i2c-gpio.c
> @@ -265,7 +265,7 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev)
> */
> if (!i2c_gpio_debug_dir) {
> i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL);
> - if (!i2c_gpio_debug_dir)
> + if (IS_ERR(i2c_gpio_debug_dir))
> return;
> }
>
> --
> 2.39.0
>
