On Fri, Jun 23, 2023 at 12:03:56PM +0200, Wolfram Sang wrote: > > > - clk_unprepare(i2c->clk); > > - clk_unprepare(i2c->pclk); > > Are you sure we can use devm_clk_get_enabled() here which calls > clk_disable_unprepare() on remove and not clk_unprepare()? Unless I am missing something, I think so. This is what the driver does, gets the clock and enables it. I don't know why there is just unprepare() and not disable_unprepare() in this function. I think the patch is correct, maybe Krzysztof and Alim might spot something that I have missed. Thanks, Andi
