Hi Rob,
On Fri, Jun 09, 2023 at 12:30:44PM -0600, Rob Herring wrote:
> Use the recently added of_property_read_reg() helper to get the
> untranslated "reg" address value.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-mpc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> index cfd074ee6d54..595dce9218ad 100644
> --- a/drivers/i2c/busses/i2c-mpc.c
> +++ b/drivers/i2c/busses/i2c-mpc.c
> @@ -316,9 +316,10 @@ static void mpc_i2c_setup_512x(struct device_node *node,
> if (node_ctrl) {
> ctrl = of_iomap(node_ctrl, 0);
> if (ctrl) {
> + u64 addr;
> /* Interrupt enable bits for i2c-0/1/2: bit 24/26/28 */
> - pval = of_get_property(node, "reg", NULL);
> - idx = (*pval & 0xff) / 0x20;
> + of_property_read_reg(node, 0, &addr, NULL);
because of_property_read_reg() can return error, can we check
also the error value here?
Thanks,
Andi
> + idx = (addr & 0xff) / 0x20;
> setbits32(ctrl, 1 << (24 + idx * 2));
> iounmap(ctrl);
> }
> --
> 2.39.2
>
