Tue, May 30, 2023 at 02:11:08PM +0800, Jiawen Wu kirjoitti:
> On Saturday, May 27, 2023 4:44 PM, Andy Shevchenko wrote:
> > On Wed, May 24, 2023 at 05:17:14PM +0800, Jiawen Wu wrote:
...
> > > +int txgbe_init_phy(struct txgbe *txgbe)
> > > +{
> > > + int ret;
> > > +
> > > + ret = txgbe_swnodes_register(txgbe);
> > > + if (ret) {
> > > + wx_err(txgbe->wx, "failed to register software nodes\n");
> >
> > > + return ret;
> > > + }
> > > +
> > > + return 0;
> >
> > These 4 lines can be as simple as
> >
> > return ret;
>
> This function is going to be extended with later patches, is it necessary to
> simply it here?
Nope, thank you for elaboration.
> > > +}
--
With Best Regards,
Andy Shevchenko
