Re: [RFC PATCH 1/6] i2c: acpi: set slave mode flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 25, 2023 at 6:22 PM Jonathan Cameron
<Jonathan.Cameron@xxxxxxxxxx> wrote:
>
> If the GenericSerialBusConnection includes the General Flag
> for slave mode set it during parsing.

Since it's obvious that you are using the existing ACPI specification
bits, it's a nice patch!
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Nevertheless the remark is that most likely this feature was never
tested on the ACPI implementations other than ACPICA (evidently by
you). Would it be interesting to know Microsoft's point of view on
this.

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
>  drivers/i2c/i2c-core-acpi.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c
> index d6037a328669..7dda5eab9645 100644
> --- a/drivers/i2c/i2c-core-acpi.c
> +++ b/drivers/i2c/i2c-core-acpi.c
> @@ -125,6 +125,9 @@ static int i2c_acpi_fill_info(struct acpi_resource *ares, void *data)
>         if (sb->access_mode == ACPI_I2C_10BIT_MODE)
>                 info->flags |= I2C_CLIENT_TEN;
>
> +       if (sb->slave_mode)
> +               info->flags |= I2C_CLIENT_SLAVE;
> +
>         return 1;
>  }
>
> --
> 2.39.2
>


-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux