On Tue, 09 May 2023, Benjamin Bara wrote: > From: Benjamin Bara <benjamin.bara@xxxxxxxxxxx> > > There are a couple of boards which use a tps6586x as > "ti,system-power-controller", e.g. the tegra20-tamonten.dtsi. > For these, the only registered restart handler is the warm reboot via > tegra's PMC. As the bootloader of the tegra20 requires the VDE, it must > be ensured that VDE is enabled (which is the case after a cold reboot). > For the "normal reboot", this is basically the case since 8f0c714ad9be. > However, this workaround is not executed in case of an emergency restart. > In case of an emergency restart, the system now simply hangs in the > bootloader, as VDE is not enabled (because it is not used). > > The TPS658629-Q1 provides a SOFT RST bit in the SUPPLYENE reg to request > a (cold) reboot, which takes at least 20ms (as the data sheet states). > This avoids the hang-up. > > Tested on a TPS658640. > > Signed-off-by: Benjamin Bara <benjamin.bara@xxxxxxxxxxx> > --- > drivers/mfd/tps6586x.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) I plan to apply the whole set once you have all required Acks. For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones <lee@xxxxxxxxxx> -- Lee Jones [李琼斯]
