On Wed, May 17, 2023 at 5:56 AM Jiawen Wu <jiawenwu@xxxxxxxxxxxxxx> wrote: > > > > > > + gc = devm_kzalloc(dev, sizeof(*gc), GFP_KERNEL); > > > > > + if (!gc) > > > > > + return -ENOMEM; > > > > > + > > > > > + gc->label = devm_kasprintf(dev, GFP_KERNEL, "txgbe_gpio-%x", > > > > > + (wx->pdev->bus->number << 8) | wx->pdev->devfn); > > > > > + gc->base = -1; > > > > > + gc->ngpio = 6; > > > > > + gc->owner = THIS_MODULE; > > > > > + gc->parent = dev; > > > > > + gc->fwnode = software_node_fwnode(txgbe->nodes.group[SWNODE_GPIO]); > > > > > > > > Looking at the I²C case, I'm wondering if gpio-regmap can be used for this piece. > > > > > > I can access this GPIO region directly, do I really need to use regmap? > > > > It's not a matter of access, it's a matter of using an existing > > wrapper that will give you already a lot of code done there, i.o.w. > > you don't need to reinvent a wheel. > > I took a look at the gpio-regmap code, when I call devm_gpio_regmap_register(), > I should provide gpio_regmap_config.irq_domain if I want to add the gpio_irq_chip. > But in this use, GPIO IRQs are requested by SFP driver. How can I get irq_domain > before SFP probe? And where do I add IRQ parent handler? Summon Michael who can probably answer this better than me. -- With Best Regards, Andy Shevchenko
