Hi,
Acked-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
Regards,
Alain
On Mon, May 08, 2023 at 10:52:47PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index d1c59d83a65b..e897d9101434 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -2309,7 +2309,7 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int stm32f7_i2c_remove(struct platform_device *pdev)
> +static void stm32f7_i2c_remove(struct platform_device *pdev)
> {
> struct stm32f7_i2c_dev *i2c_dev = platform_get_drvdata(pdev);
>
> @@ -2341,8 +2341,6 @@ static int stm32f7_i2c_remove(struct platform_device *pdev)
> stm32f7_i2c_write_fm_plus_bits(i2c_dev, false);
>
> clk_disable_unprepare(i2c_dev->clk);
> -
> - return 0;
> }
>
> static int __maybe_unused stm32f7_i2c_runtime_suspend(struct device *dev)
> @@ -2486,7 +2484,7 @@ static struct platform_driver stm32f7_i2c_driver = {
> .pm = &stm32f7_i2c_pm_ops,
> },
> .probe = stm32f7_i2c_probe,
> - .remove = stm32f7_i2c_remove,
> + .remove_new = stm32f7_i2c_remove,
> };
>
> module_platform_driver(stm32f7_i2c_driver);
> --
> 2.39.2
>
