> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Sent: Monday, 8 May 2023 23:52
> To: Vadim Pasternak <vadimp@xxxxxxxxxx>; Michael Shych
> <michaelsh@xxxxxxxxxx>; Wolfram Sang <wsa@xxxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx
> Subject: [PATCH 39/89] i2c: mlxcpld: Convert to platform remove callback
> returning void
>
> The .remove() callback for a platform driver returns an int which makes many
> driver authors wrongly assume it's possible to do error handling by returning
> an error code. However the value returned is (mostly) ignored and this
> typically results in resource leaks. To improve here there is a quest to make
> the remove callback return void. In the first step of this quest all drivers are
> converted to .remove_new() which already returns void.
>
> Trivially convert this driver from always returning zero in the remove callback
> to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Acked-by: Vadim Pasternak <vadimp@xxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-mlxcpld.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mlxcpld.c b/drivers/i2c/busses/i2c-
> mlxcpld.c
> index 081f51ef0551..c42fd4b329e4 100644
> --- a/drivers/i2c/busses/i2c-mlxcpld.c
> +++ b/drivers/i2c/busses/i2c-mlxcpld.c
> @@ -571,19 +571,17 @@ static int mlxcpld_i2c_probe(struct
> platform_device *pdev)
> return err;
> }
>
> -static int mlxcpld_i2c_remove(struct platform_device *pdev)
> +static void mlxcpld_i2c_remove(struct platform_device *pdev)
> {
> struct mlxcpld_i2c_priv *priv = platform_get_drvdata(pdev);
>
> i2c_del_adapter(&priv->adap);
> mutex_destroy(&priv->lock);
> -
> - return 0;
> }
>
> static struct platform_driver mlxcpld_i2c_driver = {
> .probe = mlxcpld_i2c_probe,
> - .remove = mlxcpld_i2c_remove,
> + .remove_new = mlxcpld_i2c_remove,
> .driver = {
> .name = MLXCPLD_I2C_DEVICE_NAME,
> },
> --
> 2.39.2
