Hi Jarkko, On Mon, 24 Apr 2023 13:57:57 +0300, Jarkko Nikula wrote: > Add SMBus PCI ID on Intel Meteor Lake PCH-S. Also called as Meteor > Point-S which is used in the code to distinguish from Meteor Lake-S SoC > but call both as Meteor Lake in documentation and Kconfig. > > Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> > --- > Hi Jean. This is essentially the same than v1 with following minor > changes: > v2: "SOC/PCH" -> "SOC and PCH" in documentation and Kconfig. PCI ID > define according to updated patch 1/2. My initial concerns partly stand. You add a device named "Meteor Point-S" to the driver, but you list that device under name "Meteor Lake-S" in the documentation (and Kconfig). This is confusing and I can't see the rationale. Surely the device has one name, and you should use that name both in the driver and the documentation. Thanks, -- Jean Delvare SUSE L3 Support
