On Tue, Apr 25, 2023 at 04:08:59PM +0200, Andi Shyti wrote: > > > #define MODEL_MSCC_OCELOT BIT(8) > > > #define MODEL_BAIKAL_BT1 BIT(9) > > > #define MODEL_AMD_NAVI_GPU BIT(10) > > > +#define MODEL_WANGXUN_SP BIT(11) > > > #define MODEL_MASK GENMASK(11, 8) > > > > Yeah, maybe next one will need to transform this from bitfield to plain number. > > You mean this? No, only MODEL_XXX bits. > -#define ACCESS_INTR_MASK BIT(0) > -#define ACCESS_NO_IRQ_SUSPEND BIT(1) > -#define ARBITRATION_SEMAPHORE BIT(2) > - > -#define MODEL_MSCC_OCELOT BIT(8) > -#define MODEL_BAIKAL_BT1 BIT(9) > -#define MODEL_AMD_NAVI_GPU BIT(10) > -#define MODEL_MASK GENMASK(11, 8) > +#define ACCESS_INTR_MASK 0x00 > +#define ACCESS_NO_IRQ_SUSPEND 0x01 > +#define ARBITRATION_SEMAPHORE 0x02 > + > +#define MODEL_MSCC_OCELOT 0x08 > +#define MODEL_BAIKAL_BT1 0x09 > +#define MODEL_AMD_NAVI_GPU 0x0a > +#define MODEL_MASK 0x78 > > I actually like more bitfield to plain numbers. Too limited. For model we get 16 out of 4 bits, which is much better and as you see we have a trend. -- With Best Regards, Andy Shevchenko
