On Tue, Apr 25, 2023 at 05:06:19PM +0200, Andi Shyti wrote:
> Hi Jiawen,
>
> [...]
>
> > + ret = txgbe_i2c_register(txgbe);
> > + if (ret) {
> > + wx_err(txgbe->wx, "failed to init i2c interface: %d\n", ret);
> > + goto err_unregister_swnode;
> > + }
> > +
> > return 0;
> > +
> > +err_unregister_swnode:
> > + software_node_unregister_node_group(txgbe->nodes.group);
> > +
> > + return ret;
>
> no need for the goto here... in my opinion it's easier if you put
> software_node_unregister_node_group() under the if and return
> ret.
please... ignore, I see that there are more goto's added in the
next patches.
Andi
